fix(schematics): fix add-icon-assets schema path
#6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #6404 +/- ##
==========================================
- Coverage 89.86% 89.85% -0.02%
==========================================
Files 478 478
Lines 15277 15277
Branches 2468 2468
==========================================
- Hits 13729 13727 -2
- Misses 930 931 +1
- Partials 618 619 +1
Continue to review full report at Codecov.
|
ZhWent
pushed a commit
to ZhWent/ng-zorro-antd
that referenced
this pull request
Mar 3, 2021
* upsteam/master: fix(schematics): fix `add-icon-assets` schema path (NG-ZORRO#6404) fix(module:tree-view): correct API typo (NG-ZORRO#6386) chore(release): release 11.1.0 (NG-ZORRO#6371) fix(module:table): fix table `nzBordered` (NG-ZORRO#6367) fix(module:typography): edit area cannot get the content (NG-ZORRO#6369) feat(module:table): add support for ReadonlyArray (NG-ZORRO#6156) build: update to 11.1 (NG-ZORRO#6365) chore: sync ant-design v4.10.3 (NG-ZORRO#6364) feat(module:table): support nzPaginationType property (NG-ZORRO#5986) feat(module:date-picker): support nzId (NG-ZORRO#6242) (NG-ZORRO#6246) feat(module:upload): support `NzUploadFile` parameter of `nzIconRender` (NG-ZORRO#6283) feat(module:modal): add nzCentered for modal (NG-ZORRO#6333) chore: sync ant-design v4.10.2 (NG-ZORRO#6334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
collection.json中的add-icon-assets配置引用了一个错误的schema路径，导致如果其他 schematics 扩展了 ng-zorro-antd 的 schematics 后，执行ng g --help命令会由于配置不正确而报错经查找，应该在某次提交 69072de 中，原有的
schema.json被移除了简单起见，复用了
blankschematic 目录中的schema.json（因为 git 的 diff 结果也是显示 boot-page 被重命名为 blank 了）What is the new behavior?
正确引用相应的
schema.jsonDoes this PR introduce a breaking change?
Other information
add-icon-assets实际上已经被移动到 setup-project 中作为项目初始化的一个Rule来用了，是否可以考虑废弃该公共 schematic